Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross rust2 #1363

Merged
merged 2 commits into from
Feb 1, 2025
Merged

Fix cross rust2 #1363

merged 2 commits into from
Feb 1, 2025

Conversation

symphorien
Copy link
Contributor

fixes for the darwin issue in #1360 (comment)

I don't have access to darwin, tested by autoreconf -fv && ./configure --host x86_64-apple-darwin22.6.0 CC=cc

for the musl issue the error message is quite clear: to cross compile rust to musl you need the corresponding toolchain. How did it even work before?

strip the version number at the end of the target triple

configure: error: "/Users/runner/.cargo/bin/rustc knows neither x86_64-apple-darwin22.6.0 nor x86_64-unknown-darwin22.6.0"
@symphorien
Copy link
Contributor Author

ping @tstack

@tstack tstack merged commit 40ca817 into tstack:master Feb 1, 2025
0 of 5 checks passed
@tstack tstack mentioned this pull request Feb 1, 2025
@tstack
Copy link
Owner

tstack commented Feb 1, 2025

This is still not passing CI

@symphorien
Copy link
Contributor Author

yes, that's what I meant by

for the musl issue the error message is quite clear: to cross compile rust to musl you need the corresponding toolchain. How did it even work before?

For context, the precise error message is:

error[E0463]: can't find crate for `core`
  |
  = note: the `x86_64-unknown-linux-musl` target may not be installed
  = help: consider downloading the target with `rustup target add x86_64-unknown-linux-musl`

Unfortunately the dockerfile for the build image is not in this repo so that's not something I can fix myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants